Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: errors on ses #596

Merged
merged 50 commits into from
Nov 7, 2024
Merged

fix: errors on ses #596

merged 50 commits into from
Nov 7, 2024

Conversation

andreabadesso
Copy link
Contributor

Acceptance Criteria

  • These patches fix situations where SES blocked libraries from mutating javascript native objects
  • We also fix a race condition caused by react-native-mmkv blocking execution.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

andreabadesso and others added 30 commits April 15, 2024 13:18
@andreabadesso
refactor: feature toggle using hathor unleash client
12cd003
@andreabadesso
feat: handling feature updates
2321a4b
@andreabadesso
feat: added SES to the project and enabled lockdown
5b96742
@andreabadesso
chore: added patch-package and patch to react-native
dc8b070
@andreabadesso
chore: removed unused diff from react-native patch
d64cf5b
@andreabadesso
chore: added allow-scripts
d79c37e
@andreabadesso
chore: added updated allowScript config
599365f
@andreabadesso
chore: added sha256sum of lockdown file
d176271
@andreabadesso
refactor: moved lavamoat lockdown to a patch instead of entrypoint
b79ad5a
@andreabadesso
refactor: removed ses from package.json, reading from file
7cfdc44
@andreabadesso
chore: fix lint by ignoring lockdown
f5b5aa3
@andreabadesso
chore: allowing root postinstall and running allow-scripts on npm run…
ca46bdb 
… setup
@andreabadesso
chore: added comment explaining why we can't use hermes
2821355
@andreabadesso
chore: uninstall ses as we're using a downloaded file
e46a8b7
@andreabadesso
chore: removed unused diff from react-native patch
126ec60
@andreabadesso
chore: no need to remove polyfill promise as injecting it on initiali…
c7d3c22 
…zeCore fixes the issue
@andreabadesso
chore: updated react-native patch to include react-native-mmkv and us…
9848a0c 
…e it
@andreabadesso
feat: added ses saga and restarting bundle when ses is disabled
ae2af0f
@andreabadesso
chore: added a document explaining how to update SES
ffff5b3
@andreabadesso
chore: added postinstall to setup script and updated packages
4929736
@andreabadesso
chore: fixed allow-scripts version
7f75836
@andreabadesso
chore: added patch-package to postinstall
fcbc5f0
@andreabadesso
chore: added MKMV to podfile.lock
98b3ac1
@andreabadesso
chore: reading ses enabled from constant
caa2295
@andreabadesso
feat: yield fatal error when SES should be enabled but is not
3c7a128
@andreabadesso
refactor: improved verifySesEnabled method
ea15c73
@andreabadesso
Merge branch 'master' into feat/lavamoat-integration
fb721f9
@alexruzenhack @andreabadesso
chore: update sentry version (#578)
2ee7006
@andreabadesso
feat: update SES to 1.5.0
3b61dc1
@andreabadesso
feat: patched intl to work in SES
bb4ccd0
@andreabadesso andreabadesso self-assigned this Nov 6, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Nov 6, 2024
tuliomir
tuliomir approved these changes Nov 6, 2024
View reviewed changes
patches/react+18.2.0.patch

- Error.prepareStackTrace = undefined;
+ // XXX: SES blocks this, it shouldn't. This will cause us to have less information on dev logs.
+ // We should remove this comment after this is fixed on SES side.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Do we have an issue we can track for this on SES repos?

Just in case this is forgotten for a while, the developer that eventually picks it up can immediately check some resource to understand if it's safe to remove this patch already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it was fixed:
endojs/endo#251

But stills throws an error here.

I'll open a KTLO to investigate this deeper

But since this only fails in dev, I'll continue with the merge

@andreabadesso andreabadesso force-pushed the feat/lavamoat-integration branch 2 times, most recently from 4c95a93 to e9a0644 Compare November 7, 2024 01:43
Base automatically changed from feat/lavamoat-integration to master November 7, 2024 10:57
@andreabadesso andreabadesso merged commit a0b6a8a into master Nov 7, 2024
1 check passed
@andreabadesso andreabadesso deleted the fix/errors-on-ses branch November 7, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreabadesso @tuliomir @pedroferreira1 @alexruzenhack