Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race with the correct actions in create transaction saga #632

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: race with the correct actions in create transaction saga #632

merged 1 commit into from
Nov 13, 2024

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Nov 13, 2024 •
edited
Loading

Acceptance Criteria

  • Reown would freeze after a failure in create nano contract RPC request because it was expecting an action that was never fired

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso requested review from tuliomir and pedroferreira1 and removed request for pedroferreira1 November 13, 2024 22:14
@andreabadesso andreabadesso self-assigned this Nov 13, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Nov 13, 2024
@andreabadesso andreabadesso merged commit 1ff5639 into master Nov 13, 2024
1 check passed
andreabadesso added a commit that referenced this pull request Nov 13, 2024
@andreabadesso
fix: race with the correct actions in create transaction saga (#632)
8479720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabadesso @tuliomir @pedroferreira1