Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes pin and password from Redux #607

Merged
merged 2 commits into from
May 10, 2024

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented May 7, 2024

This PR removes the Pin and Password information from Redux, and instead keeps it in the smallest scope possible within the component state of the NewWallet and LoadWallet screens.

This avoids any future bugs where the Redux store cleanup fails or even security issues should the Redux store happen to leak.

Acceptance Criteria

  • Pin and Password should never be stored on Redux

Notes

To facilitate the refactor, the ChossePassword and ChoosePin components were refactored to functional components.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the enhancement New feature or request label May 7, 2024
@tuliomir tuliomir self-assigned this May 7, 2024
@tuliomir tuliomir removed the request for review from pedroferreira1 May 7, 2024 23:52
@tuliomir tuliomir force-pushed the refactor/pin-passwd-state branch from 1b00dd0 to b84b24c Compare May 8, 2024 15:23
@tuliomir tuliomir merged commit 9cc1499 into master May 10, 2024
1 check passed
@tuliomir tuliomir deleted the refactor/pin-passwd-state branch May 10, 2024 16:32
@pedroferreira1 pedroferreira1 mentioned this pull request Jul 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants