Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: native token config #636

Merged
merged 12 commits into from
Jul 3, 2024
Merged

feat: native token config #636

merged 12 commits into from
Jul 3, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Jun 25, 2024 •
edited
Loading

Acceptance Criteria

  • Remove all uses of HATHOR_TOKEN_CONFIG in favor of NATIVE_TOKEN_UID and the configured native token.
  • Start the wallet by adding the native token received from the fullnode

Requires HathorNetwork/hathor-wallet-lib#689 to be merged and released.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Jun 25, 2024
@r4mmer r4mmer requested a review from tuliomir June 26, 2024 16:40
pedroferreira1
pedroferreira1 reviewed Jun 28, 2024
View reviewed changes
src/screens/CustomTokens.js Show resolved Hide resolved
src/actions/index.js Show resolved Hide resolved
src/reducers/index.js Outdated Show resolved Hide resolved
src/reducers/index.js Show resolved Hide resolved
src/sagas/wallet.js Outdated Show resolved Hide resolved
src/sagas/wallet.js Outdated Show resolved Hide resolved
tuliomir
tuliomir reviewed Jul 1, 2024
View reviewed changes
src/reducers/index.js Show resolved Hide resolved
src/reducers/index.js Show resolved Hide resolved
src/reducers/index.js Show resolved Hide resolved
src/components/tokens/TokenMint.js Show resolved Hide resolved
pedroferreira1
pedroferreira1 approved these changes Jul 2, 2024
View reviewed changes
src/actions/index.js Show resolved Hide resolved
@r4mmer r4mmer merged commit 3b5f502 into master Jul 3, 2024
1 check passed
@r4mmer r4mmer deleted the feat/native-token-config branch July 3, 2024 15:24
r4mmer added a commit that referenced this pull request Jul 3, 2024
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/decimal-places…
3c87784 
…-config

* origin/master:
  feat: native token config (#636)
@pedroferreira1 pedroferreira1 mentioned this pull request Jul 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@r4mmer r4mmer

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r4mmer @tuliomir @pedroferreira1