Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore e2e tests #698

Merged
merged 9 commits into from
Dec 10, 2024
Merged

fix: Restore e2e tests #698

merged 9 commits into from
Dec 10, 2024

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented Nov 27, 2024

Acceptance Criteria

  • Restores e2e tests
  • Adds coverage to:
    • Starting a new wallet with no backup
    • Backing up words
    • Successfully fetching tx history from fullnode
    • Handling fullnode failure on fetch tx history
  • Partially solves Restore automated tests #696

Notes

These initial tests serve as a proof of concept for end to end testing on the Desktop Wallet, allowing us to aim at having the full QA executed automatically. It will be open to analysis if we should run the full QA at each CI iteration, or what part of the coverage should be run at developer machines.

The next PRs should include relevant plugins like the ones that execute visual inspection on the screens, but are outside the scope of this basic test restoration.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Nov 27, 2024
@tuliomir tuliomir marked this pull request as ready for review December 2, 2024 18:37
@tuliomir tuliomir mentioned this pull request Dec 6, 2024
1 task
@tuliomir tuliomir merged commit b2da190 into master Dec 10, 2024
4 checks passed
@tuliomir tuliomir deleted the fix/restore-tests branch December 10, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants