-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Restore e2e tests #698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliomir
force-pushed
the
fix/restore-tests
branch
from
November 28, 2024 00:54
ff83d41
to
6eea337
Compare
tuliomir
commented
Dec 2, 2024
andreabadesso
approved these changes
Dec 9, 2024
pedroferreira1
approved these changes
Dec 10, 2024
tuliomir
force-pushed
the
fix/restore-tests
branch
from
December 10, 2024 16:03
6eea337
to
52ebe7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Notes
These initial tests serve as a proof of concept for end to end testing on the Desktop Wallet, allowing us to aim at having the full QA executed automatically. It will be open to analysis if we should run the full QA at each CI iteration, or what part of the coverage should be run at developer machines.
The next PRs should include relevant plugins like the ones that execute visual inspection on the screens, but are outside the scope of this basic test restoration.
Security Checklist