fix: do not use mutable data structure as argument #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
approved these changes
Dec 12, 2023
tuliomir
approved these changes
Dec 12, 2023
Merged
luislhl
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
We had a bug where 2 different instances of the
Healthcheckclass would share the same list of components, because the components were initialized using a list as default argument for the class__init__method.This bug should be fixed now.
We should also avoid this kind of bug from happening in the future, by using the
flake8-bugbearplugin to flake8. It will automatically detect this problem in case someone falls in the same trap.