Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A list of small improvements #12

Conversation

fcollonval
Copy link

@fcollonval fcollonval commented Sep 7, 2023

  • Fix dep wrongly specified as dev deps
  • Restore CSS scoping
  • Reduce diff due to format per Vidar comment
  • Restore getMergedValue
  • Improve integration tests config
    • Reduce the test matrix (no point to test multiple Python)
    • Test the package installed from wheel not dev
    • Remove unused ref snapshots
  • Add integration test for checking resolved conflict download
  • Symlink example to ui test to avoid content duplication
  • Instantiate editor registries only once (propagate them from top to bottom to reuse tokens in lab)
  • Improve API by switching to object instead of args array in all places changes were needed to the API
  • Don't clean the favicon when running npm run clean
  • Fix lumino and lab styles not being deduplicated in the webapp (the app is much more reactive and FF stops crashing when using the dev tools)
  • Use only prebuilt lab extension
  • Modernize Jest config

@fcollonval
Copy link
Author

cc @krassowski for awareness

@krassowski
Copy link

If that helps I have the actions enabled on my master branch, so the new snapshots can be grabbed from krassowski#5 (or by opening a PR and triggering bot via comment to get them directly).

@fcollonval
Copy link
Author

Thanks a lot Mike, I'll take the new snapshots from your branch.

@HaudinFlorence HaudinFlorence merged commit e345cd7 into HaudinFlorence:upgrate_nbdime_for_jupyterlab_4 Sep 8, 2023
10 checks passed
@fcollonval fcollonval deleted the small-things branch September 8, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants