Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free resources upon exit #258

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Free resources upon exit #258

merged 2 commits into from
Feb 21, 2023

Conversation

S4ntiagoP
Copy link
Contributor

@S4ntiagoP S4ntiagoP commented Feb 20, 2023 •
edited
Loading

This PR includes:

  • the release of resources upon exit (I have surely missed some)
  • the reconnect fix that's already on main
  • a minor bug on the parsing of the "socks add" parameter
  • a few entries to the .gitignore
  • a small bug fix in ConsoleInput.cpp

@winterrdog
Copy link

Neat stuff 👌

@S4ntiagoP
small refactor in ConsoleImput.cpp
2abee84 
if a python script returns None, the client interprets that as an error and shows the first parameter to the user.
if the command entered had no parameters, the client will seg fault. Now, the index 0 is shown to the user.

Lastly, if the script returns True, the client does not interpret that as en error.
this is simply to allow scripts to show some message to the user and
exit gracefully (purely aesthetics, not a bug)
@Cracked5pider
Copy link
Member

Thank you so much for contributing to this project.

@Cracked5pider Cracked5pider merged commit d94e191 into HavocFramework:dev Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S4ntiagoP @winterrdog @Cracked5pider