Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Shaders #399

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Runtime Shaders #399

merged 4 commits into from
Aug 7, 2023

Conversation

MAJigsaw77
Copy link
Contributor

Using the base code from EliteMasterEric's pull request, this removes version stuff to not break non desktop platforms and supports the current version of openfl (flash can't use this class).

@Geokureli
Copy link
Member

@EliteMasterEric when you get a moment could you look over this? I know you were working on this here, but yours requires a change to openfl. This seems to work, as is

Letting users to chose where own way to load shaders
@EliteMasterEric
Copy link

@Geokureli I will have to look into testing this later, but with a look over the codebase I will say it will probably function.

The ideal way to test is to switch this project to use current Lime and this branch and test: https://github.com/EliteMasterEric/Flixel-GalaxyShaderWorkbench

This code is definitely not ideal, however; it is based on an old version of my PR, which duplicates a lot of code from FlxGraphicsShader. It also, as mentioned, removes the version stuff, which means GLSL 300 es cannot be opted into.

@MAJigsaw77
Copy link
Contributor Author

@Geokureli I will have to look into testing this later, but with a look over the codebase I will say it will probably function.

The ideal way to test is to switch this project to use current Lime and this branch and test: https://github.com/EliteMasterEric/Flixel-GalaxyShaderWorkbench

This code is definitely not ideal, however; it is based on an old version of my PR, which duplicates a lot of code from FlxGraphicsShader. It also, as mentioned, removes the version stuff, which means GLSL 300 es cannot be opted into.

It works fine from what I can tell
https://github.com/MAJigsaw77/FlxRuntimeShader-Test

@MAJigsaw77
Copy link
Contributor Author

If you are really worried about code duplication, it can be fixed using some macros but for now is fine

@Geokureli
Copy link
Member

yeah I'm not worried about code duplication that can be fixed after the merge

@Geokureli Geokureli merged commit f0b2b4f into HaxeFlixel:dev Aug 7, 2023
@Geokureli
Copy link
Member

thanks!

@MAJigsaw77 MAJigsaw77 deleted the dev-1 branch August 7, 2023 04:27
Geokureli added a commit that referenced this pull request Aug 15, 2023
@Geokureli Geokureli mentioned this pull request Aug 17, 2023
@Geokureli
Copy link
Member

Geokureli commented Aug 21, 2023

@MAJigsaw77 lot of people are asking for examples of how to do this, previously I just told them to look at https://github.com/MAJigsaw77/FlxRuntimeShader-Test but this repo has been deleted, can you make a public example repo?

eventually I was planning to make a demo, snippet or page where people can test shaders in real time, like shadertoy.

@MAJigsaw77
Copy link
Contributor Author

I'll make the test repo public again

charlesisfeline pushed a commit to AumSum-Funkin-Team/PlutosReprisalAumSumTakeover that referenced this pull request Oct 17, 2023
- Remove `FlxRuntimeShader` since Haxeflixel added `FlxRuntimeShader` HaxeFlixel/flixel-addons#399
* Migrate `FlxAnimationController` to Flixel 5.4.1 HaxeFlixel/flixel#2930
* Fix `FlxCamera.filters` Deprecation Warning HaxeFlixel/flixel#2890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants