Auto detect window size and etc. #1811

buckle2000 · 2016-04-11T03:44:33Z

Tested. works. see here

Increase readability.

buckle2000 · 2016-04-11T03:46:28Z

Also, please change the template of Main.hx (Main.hx.tpl) into a static file (Main.hx).
${WIDTH} and ${WIDTH} can be simply replaced with 0.

buckle2000 · 2016-04-11T03:58:30Z

Added function multiply to FlxPoint.
It might be useful.
e.g.

sprite.scale.multiply(2.0)

Also, try operators overloading?

Gama11 · 2016-04-11T08:08:45Z

flixel/math/FlxPoint.hx

+	 * @param	scalar	How much times this point will be as it before.
+	 * @return	This point.
+	 */
+	public function multiply(scalar:Float):FlxPoint


FlxVector#scale() is the same thing, so this seems redundant.

It is not redundant.
Some of HaxeFlixel's code use FlxPoint instead of FlxVector.
So you have to write code like this:

point.x*=scalar; point.y*=scalar;

I'm aware, that doesn't make it any less redundant - both functions have the same implementation. Since FlxVector extends FlxPoint, FlxVector would have a scale() and a multiply().

If anything, scale() should be moved to FlxPoint().

Gama11 · 2016-04-11T08:13:21Z

flixel/FlxGame.hx

@@ -243,6 +243,14 @@ class FlxGame extends Sprite
 		// Super high priority init stuff
 		_inputContainer = new Sprite();

+		if (GameSizeX == 0)


The special meaning of 0 for GameSizeX and GameSizeY should be documented in the @param docs.

Gama11 · 2016-04-11T08:25:55Z

Also, try operators overloading?

Operator overloading only works for abstracts. I've experimented with it a bit once... You would need a FlxPoint abstract and a FlxPointImpl class or something of the sort. I think I had some issues with methods that return FlxPoint instances / this, but I don't remember why exactly.

Operator overloading might be supported via static extensions in Haxe 4 (HaxeFoundation/haxe#2803), which would be quite convenient. Of course, that's not gonna be available anytime soon.

Gama11 · 2016-04-11T08:27:14Z

flixel/math/FlxPoint.hx

+	 * @param	k - scale coefficient
+	 * @return	scaled vector
+	 */
+	public inline function scale(k:Float):FlxVector


This still returns a FlxVector and says @return scaled vector.

Hm, this is going to result in sprite.scale.scale(), which looks quite weird... Oh well.

Gama11 · 2016-04-11T08:37:44Z

flixel/math/FlxVector.hx

+     * @param   k - scale coefficient
+     * @return  scaled vector
+     */
+    public inline override function scale(k:Float):FlxVector


An inlined function can't be overriden. Are you actually compiling this code locally? ;)

Oh no. both with override or without override failed.
I tried this:

class A{ public static function main(){ new B().a(); } } class B extends C { public **override** inline function a():B { return this; } } class C { public inline function a():C { return this; } }

with override:

Field a is inlined and cannot be overridden

without:

Field a should be declared with 'override' since it is inherited from superclass C

wtf

The problem is that FlxPoint#scale() is inline - you can't override a function that is inline, otherwise the compiler wouldn't be able to inline it anymore.

You definitely can't omit the override keyword.

Gama11 · 2016-04-11T08:38:15Z

flixel/FlxGame.hx

@@ -223,16 +223,16 @@ class FlxGame extends Sprite
 	/**
 	 * Instantiate a new game object.
 	 * 
-	 * @param	GameSizeX		The width of your game in game pixels, not necessarily final display pixels (see Zoom).
-	 * @param	GameSizeY		The height of your game in game pixels, not necessarily final display pixels (see Zoom).
+	 * @param	GameSizeX		The width of your game in game pixels, not necessarily final display pixels (see Zoom). If it is less than 0, HaxeFlixel will auto detect the width according to the current window.


These docs are not quite accurate, they only account for the < 0 case, not == 0.

buckle2000 · 2016-04-11T08:39:33Z

Also, template change.

Gama11 · 2016-04-11T09:01:23Z

flixel/FlxGame.hx

@@ -243,6 +243,14 @@ class FlxGame extends Sprite
 		// Super high priority init stuff
 		_inputContainer = new Sprite();

+		if (GameSizeX <= 0)


Maybe we should stick to only == 0. Something like new FlxGame(-10, -50, PlayState) would result in windowSize x windowHeight, which seems a little weird.

Sorry, I don't understand what do you mean by windowSize x windowHeight.
Another reason I can think of is to reserve the negative values for possible more implements in the future.

I meant windowWidth x windowHeight.

What I meant is that it seems confusing to the reader that random negative values would turn into a FlxGame instance which uses the window dimensions, wheareas with 0, you can at least guess that it probably has some special meaning.

I changed the comments, so it is easier to be understood.
Just think if somehow a negative value is passed in, FlxGame can deal with it.

buckle2000 · 2016-04-11T09:20:20Z

just keep both multiply and scale.

Gama11 · 2016-04-11T09:24:01Z

Why? I don't agree with that. Having two functions in FlxVector that do the same thing is bad API design.

Gama11 · 2016-04-11T09:30:42Z

flixel/FlxGame.hx

@@ -243,6 +243,14 @@ class FlxGame extends Sprite
 		// Super high priority init stuff
 		_inputContainer = new Sprite();

+		if (GameSizeX <= 0)
+		{
+			GameSizeX = Std.int(Lib.current.stage.window.width);


We can't use .window here, needs to be stageWidth and stageHeight (Travis is currently failing because Stage#window doesn't exist in OpenFL legacy).

I have tried using Lib.current.stage.width but not Lib.current.stage.*window*.width.
BUT, Lib.current.stage.width IS 0! I don't know why.
I figured that out when targeting flash.
Oh, also it is a reason not to use FlxG.stage.width.

stage.stageWidth, not stage.width.

Sorry, I thought they are the same.
stage.stageWidth does work.

buckle2000 · 2016-04-11T09:50:26Z

Well, if not, how to solve the "inline" problem?
remove inline?
use some dark magic of haxe to make multiiply un-accessible in FlxVector?
or just forget about that multiply?

Gama11 · 2016-04-11T10:09:40Z

Yeah, just remove the inline. It's only a minor optimization.

buckle2000 · 2016-04-11T11:08:09Z

OK.
Another question:
as you mentioned:

Having two functions in FlxVector that do the same thing is bad API design.

What about FlxVector.clone and FlxPoint.copyTo?

Gama11 · 2016-04-11T11:10:39Z

Yeah, not a fan of that.

buckle2000 and others added 11 commits March 13, 2016 14:27

Update FlxText.hx

dd7fc91

Increase readability.

fixed something

535f5c8

fixed something

c66c350

revert

7257057

Update FlxTilemap.hx

c243bbb

Update FlxTilemap.hx

5309f79

Update FlxTilemap.hx

63e0406

Update FlxTilemap.hx

3a6caf0

Update FlxTilemap.hx

bb2d895

Auto check window size

feae523

Merge branch 'dev' of https://github.com/buckle2000/flixel into dev

3730d00

add a improvement to FlxPoint

e365f2a

buckle2000 changed the title ~~Auto detect window size.~~ Auto detect window size and etc. Apr 11, 2016

Gama11 reviewed Apr 11, 2016
View reviewed changes

Update FlxGame.hx

d0e5732

Gama11 reviewed Apr 11, 2016
View reviewed changes

buckle2000 added 2 commits April 11, 2016 16:14

Update FlxPoint.hx

ea5d7ee

Update FlxGame.hx

098606e

Gama11 added the New Feature label Apr 11, 2016

Gama11 added this to the 4.1.0 milestone Apr 11, 2016

moved FlxVector#scale

4a1714e

Gama11 reviewed Apr 11, 2016
View reviewed changes

fixed scale function of FlxVector

7f5c388

Gama11 reviewed Apr 11, 2016
View reviewed changes

keep the two functions

16ae6e4

Gama11 reviewed Apr 11, 2016
View reviewed changes

Update FlxGame.hx

4f0c996

buckle2000 added 2 commits April 11, 2016 17:57

use stage.stageWidth instead

0c30773

Merge branch 'dev' of https://github.com/buckle2000/flixel into dev

d516806

remove inline from FlxVector#scale

fa34754

Gama11 merged commit 5f271eb into HaxeFlixel:dev Apr 11, 2016

Gama11 added a commit that referenced this pull request Apr 11, 2016

Minor cleanup (#1811)

b3677d1

Gama11 pushed a commit to HaxeFlixel/flixel-templates that referenced this pull request Apr 11, 2016

Update for HaxeFlixel/flixel#1811 (#25)

51d1e68

buckle2000 mentioned this pull request Apr 11, 2016

Update for HaxeFlixel/flixel#1811 HaxeFlixel/flixel-templates#25

Merged

buckle2000 mentioned this pull request May 13, 2016

Auto fullscreen on non-desktop platforms #1852

Open

Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this pull request Apr 18, 2018

FlxGame#new() auto-size, add FlxPoint#scale() (HaxeFlixel#1811)

9d36cc2

Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this pull request Apr 18, 2018

Minor cleanup (HaxeFlixel#1811)

44dd689

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto detect window size and etc. #1811

Auto detect window size and etc. #1811

buckle2000 commented Apr 11, 2016

buckle2000 commented Apr 11, 2016

buckle2000 commented Apr 11, 2016

Gama11 Apr 11, 2016

buckle2000 Apr 11, 2016

Gama11 Apr 11, 2016

Gama11 Apr 11, 2016

Gama11 commented Apr 11, 2016

Gama11 Apr 11, 2016

Gama11 Apr 11, 2016

Gama11 Apr 11, 2016

buckle2000 Apr 11, 2016

Gama11 Apr 11, 2016

Gama11 Apr 11, 2016

buckle2000 commented Apr 11, 2016

Gama11 Apr 11, 2016

buckle2000 Apr 11, 2016

Gama11 Apr 11, 2016

buckle2000 Apr 11, 2016

buckle2000 commented Apr 11, 2016

Gama11 commented Apr 11, 2016

Gama11 Apr 11, 2016

buckle2000 Apr 11, 2016

Gama11 Apr 11, 2016

buckle2000 Apr 11, 2016

buckle2000 commented Apr 11, 2016

Gama11 commented Apr 11, 2016

buckle2000 commented Apr 11, 2016

Gama11 commented Apr 11, 2016

Auto detect window size and etc. #1811

Auto detect window size and etc. #1811

Conversation

buckle2000 commented Apr 11, 2016

buckle2000 commented Apr 11, 2016

buckle2000 commented Apr 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gama11 commented Apr 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buckle2000 commented Apr 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buckle2000 commented Apr 11, 2016

Gama11 commented Apr 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buckle2000 commented Apr 11, 2016

Gama11 commented Apr 11, 2016

buckle2000 commented Apr 11, 2016

Gama11 commented Apr 11, 2016