-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlxTween: add .wait(), and .then() for chaining, closes #1064 #1614
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
081cc87
FlxTween: add .thenWait(), .thenTween(), and .thenWaitAndTween() func…
larsiusprime 384918c
Merge branch 'dev' of https://github.com/HaxeFlixel/flixel into tween…
larsiusprime 076302f
Refactor tween chaining
larsiusprime 17459f8
tweak
larsiusprime c7c5bcf
TweenType --> TweenMethod
larsiusprime fcac083
Cleanup tween chains
larsiusprime f071515
FlxTween: finish cleanup
larsiusprime d9cd031
Flxtween cleanup
larsiusprime 7cb4464
FlxTween: missed one
larsiusprime 9207949
FlxTween: remove waitThen()
larsiusprime ce1203b
FlxTween Fix docs
larsiusprime 2626406
Tween: fixes
larsiusprime bc2e258
FlxTween fixes
larsiusprime 9667598
Vartween: fix errant import
larsiusprime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it might fail with
wait(0)
(which should just be "no wait" - doesn't make sense if written like that but the delay could be dynamically set from some variable that happens to become 0 at some point)? And what's the expected result for negative values?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right you were, it needs to call onEnd() again in the case that delay is <= 0 AND the tween is null, signifying it's a delay that should terminate instantly and run the next "then" command.