Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for minimum node version #315

Merged
merged 4 commits into from
Sep 1, 2024

Conversation

ninjamuffin99
Copy link
Contributor

The check for the minimum supported node version would check if you had 8.x.x or above, AND if the minor version was x.10.x, meaning if you had say 9.0.0, of node, it would actually be an invalid node version, since x.0.x is smaller than x.10.x, the minor version would invalidate the node version, and it'd revert to the neko version of dox

This PR updates the check so that it'd only check the minor version if you are on node v8 exactly, anything below is invalidated otherwise

@Simn
Copy link
Member

Simn commented Sep 1, 2024

This looks more awkward than it has to, shouldn't it be something along the lines of parts[0] > 8 || parts[0] == 8 && parts[1] >= 10?

@ninjamuffin99
Copy link
Contributor Author

thatd work too, i suppose it was choice between doing a oneliner, or separating out the way i did. But this oneliner looks nice and tidy I will use that!

@Simn
Copy link
Member

Simn commented Sep 1, 2024

Thanks! I suppose we should update run.n again too.

@ninjamuffin99
Copy link
Contributor Author

doh! I knew i was forgetting something lol

@Simn Simn merged commit 3eac1d9 into HaxeFoundation:master Sep 1, 2024
4 checks passed
@skial skial mentioned this pull request Sep 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants