Fix the check for minimum node version #315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for the minimum supported node version would check if you had 8.x.x or above, AND if the minor version was x.10.x, meaning if you had say 9.0.0, of node, it would actually be an invalid node version, since x.0.x is smaller than x.10.x, the minor version would invalidate the node version, and it'd revert to the neko version of dox
This PR updates the check so that it'd only check the minor version if you are on node v8 exactly, anything below is invalidated otherwise