Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlite.hdll and mysql.hdll building on Linux #323

Conversation

jonasmalacofilho
Copy link
Member

Each of the build systems would build one of these, but not both.

@ncannasse
Copy link
Member

I think it should use the system installed libsqlite instead of the "include" one. Also it should follow fmt that has its own include paths instead of adding itself to CFLAGS

@jonasmalacofilho
Copy link
Member Author

jonasmalacofilho commented Nov 8, 2019

I think it should use the system installed libsqlite instead of the "include" one

Just following what was already in the repository and in use by cmake, but I'll gladly change this.

Also it should follow fmt that has its own include paths instead of adding itself to CFLAGS

I initially thought and did so, except that failed to build in CI, making me notice that those targets are misleading. The objects are not built with the explicit target, but rather through an implicit one.

In fact, the second third commit changes the fmt target to remove those unnecessary -I paths and avoid further confusion.

@jonasmalacofilho
Copy link
Member Author

I'm going to close this PR because it's not really relevant or useful anymore... the problem still exists, but the better fix (see comments above) will look nothing like this, and I'm not working on this.

I also apologize for saying "I'll gladly change this" and seemingly never actually getting to it. As I remember it, CMake was being annoying (or at least making me annoyed) and this got preempted by other more important or actionable things, and only then eventually forgotten at the bottom of my to-do stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants