Void as value error disappears on second compilation

[RblSb]

Regression since 4.2.5.

class Main {
	static function main() {
		// compiles fine on second build try (bad)
		// also generates empty main.js or eval null exception
		function foo():Void {}

		final arr = [
			foo(),
			// bar()
		];
	}

	// always fails (good)
	function bar():Void {}
}

Another related bug, output tab with -D message-reporting=pretty looks like this for this code:

Failed - try fixing the error(s) and restarting the language server:

�[30;41m ERROR �[0m src/Main.hx:8: characters 4-9

 8 | �[2m   �[0m�[1mfoo()�[0m�[2m,�[0m
   |    �[31m^^^^^�[0m
   | Cannot use Void as value

And it generates bad Problem info in comparison to basic reporting, so you don't see red error highlighting in file.

[kLabz]

Yeah vshaxe has not been updated for pretty errors.

[Simn]

This looks pretty bad, might suggest that some error flag isn't set correctly and the server then caches the context...

[kLabz]

I can bisect this tonight if you want (have to go for a couple hours now)

[Simn]

I'll do it

[Simn]

7321f18

Note that this only reproduces with diagnostics enabled.

[RblSb]

Fixed in #11220, but test needed

[RblSb]

https://github.com/HaxeFoundation/haxe/blob/486dfc80866173a2d57c47476e5e4590c30e3504/tests/server/src/cases/issues/Issue11184.hx