[4.3.5] Backport Json RPC diagnostics #11707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* let's see how much breaks * [tests] enable diagnostics tests for 11177 and 11184 * [tests] Update test for 5306 * Don't cache/run filters for find reference/implementation requests (#11226) * Only run filters and save cache on diagnostics, not usage requests * [tests] Update test for 11184 * disable test * add VUsedByTyper to avoid bad unused local errors * revert @:compilerGenerated change --------- Co-authored-by: Rudy Ges <k@klabz.org>
Legacy diagnostics = false, json rpc diagnostics = true
kLabz
force-pushed
the
4.3.5_json_rpc_diagnostics
branch
from
bd6b109 to
9d252ad
Compare
|
This might be a bit much for a patch release but I think it's worth it, especially with Json RPC diagnostics I kept the commit history clean for easier review. |
kLabz
force-pushed
the
4.3.5_json_rpc_diagnostics
branch
from
3b8a2c2 to
baba167
Compare
|
Tested with latest vshaxe commit, got |
|
Sounds like #11709 indeed |
|
The changes here look good to me. As I've said on Slack, it's quite a lot for a patch release, but it's a very nice cleanup, so I'm fine with merging this. |
* [diagnostics] fix json rpc diagnostics display config * [tests] Server tests: do not fail silently when runHaxeJsonCb errors * [tests] add more diagnostics tests * [display] rework multiple display files handling * clean up a bit... * [diagnostics] handle a.b.c.hx case, even if pointless * [diagnostics] do not skip errors during DisplayProcessing.process_display_file
Merged
kLabz
added a commit
that referenced
this pull request
Jul 18, 2024
* [display] diagnostics as json rpc (Backport #11412) * [tests] use json rpc diagnostics * [tests] Add test for 11695 * [tests] Update diagnostics tests * Run some filters in diagnostics (#11220) * let's see how much breaks * [tests] enable diagnostics tests for 11177 and 11184 * [tests] Update test for 5306 * Don't cache/run filters for find reference/implementation requests (#11226) * Only run filters and save cache on diagnostics, not usage requests * [tests] Update test for 11184 * disable test * add VUsedByTyper to avoid bad unused local errors * revert @:compilerGenerated change --------- Co-authored-by: Rudy Ges <k@klabz.org> * [display] get rid of TypeloadParse.current_stdin * [display] fix -D display-stdin handling * [display] generalize fileContents behavior to other json rpc display calls * [display] fix range of pattern variables Note: not including texprConverter changes see 160a490 see #7282 * [tests] add test for #7282 * [tests] add test for #7931 * Remove populateCacheFromDisplay config Legacy diagnostics = false, json rpc diagnostics = true * [std] Diagnostics request doc * [tests] Test Json RPC diagnostics with several open files * [diagnostics] fix multi display files (#11722) * [diagnostics] fix json rpc diagnostics display config * [tests] Server tests: do not fail silently when runHaxeJsonCb errors * [tests] add more diagnostics tests * [display] rework multiple display files handling * clean up a bit... * [diagnostics] handle a.b.c.hx case, even if pointless * [diagnostics] do not skip errors during DisplayProcessing.process_display_file * Enable display tests again... * [tests] fix display tests --------- Co-authored-by: Simon Krajewski <simon@haxe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developmentError range for invalid type names shouldn't include type parameters #9705This cast has no effect, but some of its sub-expressionsreport #11203Import alias marked as unused now #11516doesn't apply to4.3_bugfix(tests pass just fine but are useless there)populateCacheFromDisplay0f40f12DisplayMethods.Diagnostics... (same indevelopment)