Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error range for invalid type names shouldn't include type parameters #9705

Closed
Gama11 opened this issue Jul 10, 2020 · 1 comment
Closed

Error range for invalid type names shouldn't include type parameters #9705

Gama11 opened this issue Jul 10, 2020 · 1 comment
Assignees
@Simn
Labels
enhancement error-reporting
Milestone
Later

Comments

@Gama11
Copy link
Member

Gama11 commented Jul 10, 2020 

typedef Foo = Arrey<{
	/**
	 * test
	 */
	var test:Int;
}>;

If the outer type is misspelled, the entire range is colored red, which can be confusing / make it hard to spot the source of the problem:

image
RealyUniqueName added a commit that referenced this issue Jul 13, 2020
@RealyUniqueName
Revert "narrow error positions for "Type not found" (closes #9705)"
bd12508 
This reverts commit 5eead40.
@Gama11 Gama11 reopened this Jul 13, 2020
@RealyUniqueName RealyUniqueName added this to the Backlog milestone Jul 14, 2020
@Simn Simn removed this from the Backlog milestone Mar 24, 2023
@Simn Simn self-assigned this Mar 24, 2023
@Simn Simn modified the milestones: Release 4.3, Later Mar 24, 2023
@Simn Simn mentioned this issue Nov 22, 2023
Merged
@Simn
Copy link
Member

Simn commented Nov 22, 2023

Fixed by #11405.

@Simn Simn closed this as completed Nov 22, 2023
@kLabz kLabz mentioned this issue Jul 3, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simn Simn

Labels
enhancement error-reporting
Projects
None yet
Milestone
Later
Development

No branches or pull requests
3 participants
@Simn @Gama11 @RealyUniqueName