-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata not apply on generated @:generic classes #6500
Comments
Hmm, could you provide a reproducible example of a problem? @:keep on a @:generic file works as expected (as in - it adds @:keep meta to generic instance classes). |
http://try-haxe.mrcdk.com/#50756 to see the expected result uncomment line 7. |
Base on discussion, meta are not copied on generic instance classes, at lease on Javascript target. |
Well, looks like it's about @:keepSub, not @:keep. |
true, @:keep looks working |
* change return of build_instance to record * also rename * also seperate * also bring back typedef deprecation check * alsp keep special cases in the right place * mess around * avoid some work if we need no params anyway * make @:generic inference work again * remove Generic_Exception * push expected type before loading instance closes HaxeFoundation#3864 * expand generic types on field call candidate when expanding generic function closes HaxeFoundation#5482 * build generic parents as well closes HaxeFoundation#6761 * inherit `@:autoBuild` to generic instance closes HaxeFoundation#5536 * also inherit @:keepSub while we're at it closes HaxeFoundation#6500 * deal with KExpr in generic classes properly closes HaxeFoundation#7574 * don't inherit cf_expr_unoptimized to generic instances closes HaxeFoundation#9358 * reroute FClosure in map_expr_type closes HaxeFoundation#9395 * inherit cl_using to generic instances closes HaxeFoundation#10528 * set inherited flags on generic instance fields at the right time closes HaxeFoundation#11010 * I really don't care * wild guess * avoid the follow change
On my case, I try to apply
@:keep
on@:generic
classe, and keeping is not apply on generated classes.with Haxe Compiler 3.4.2 (git build development @ ada466c), target JS
@back2dos provide a workaround by macro, but could be better if its support directly by the Compiler. :)
The text was updated successfully, but these errors were encountered: