Use plain method closure comparison for JS. #10553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really understand what happens here because it's Javascript, but the tests are green so I'll just merge this and see if somebody complains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too proud of duplicating the code from genjs. Perhaps it would be best to expose it via
JSGenApi?In any case, my main motivation is for
Reflect.compareMethodsnot to useReflect.isFunction, because that relies on__define_feature__quite a bit, thus increasing output. I ran into this, becausehaxe.http.HttpBaseusesReflect.compareMethods(could be avoided, but I'd rather fix the underlying issue).If anyone feels strongly about having the
scopeandmethodcheck around for some weird compatibility reasons, I can instead make a PR that checks thetypeofto be"function"(instead of the fullReflect.isFunction), which should be good enough, because per spec "Iff1orf2are not functions, the result is unspecified".