Remove hx4compat stuff (part 1) #11386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm testing this with my utest branch to make sure it works, but I'd still like to only merge this once it has been fixed in real utest. |
Merged
|
Thanks for helping! The remaining JS failures all come from failing to assign I'll just swap these for now... |
|
utest2 has been merged, so now I actually have to merge this PR or else our tests won't work anymore! |
|
Ohh so that's why 😅 |
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
* destroy * update haxelib submodule * submodule * submodule ffs * cppia * remove echoServer * remove more things * more * use patched utest for now * remove one more * try utest2 * fix test * explicitly pass `null` to the `type` argument of `utest.Assert.raises()` * [php] update test HaxeFoundation#9924 for compatibility with the latest utest * [tests] type-hint Vfs.getContent * fix Vfs.getContent one more time * fix display tests * switch to utest master --------- Co-authored-by: Aleksandr Kuzmenko <alex@stablex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
sys.db,neko.Webandphp.Web. These have been moved to https://github.com/HaxeFoundation/hx4compat.Neko and PHP need an update to utest before this can be merged: haxe-utest/utest#125