Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hlc] Use uint64 instead of uint64_t for shift cast #11721

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[hlc] Use uint64 instead of uint64_t for shift cast #11721

merged 1 commit into from
Jul 18, 2024

Conversation

yuxiaomao
Copy link
Contributor

@yuxiaomao yuxiaomao commented Jul 16, 2024 •
edited
Loading

Fixes #11718

uint64 is defined in hl.h for all platforms as typedef unsigned long long uint64;, and hl.h is included everywhere, so I think it's safe to just generate based on uint64.

@kLabz kLabz added this to the 4.3 Hotfix candidates milestone Jul 18, 2024
@yuxiaomao yuxiaomao merged commit b69856b into HaxeFoundation:development Jul 18, 2024
52 checks passed
@yuxiaomao yuxiaomao deleted the dev-hlc-shiftuint64 branch July 18, 2024 10:35
@kLabz kLabz mentioned this pull request Jul 18, 2024
Merged
kLabz pushed a commit that referenced this pull request Jul 18, 2024
@yuxiaomao @kLabz
[hlc] Use uint64 instead of uint64_t for shift cast (#11721)
73e6151
kLabz pushed a commit that referenced this pull request Jul 18, 2024
@yuxiaomao @kLabz
[hlc] Use uint64 instead of uint64_t for shift cast (#11721)
636bc29
@kLabz kLabz removed this from the 4.3 Hotfix candidates milestone Jul 18, 2024
@skial skial mentioned this pull request Jul 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yuxiaomao @kLabz