Copy var flags when duplicating local variables #11803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't unroll loops that have static vars closes #11800
|
Turns out doing this for non-statics isn't so easy because of local functions and threads, so let's not do this after all. I still did some related cleanup, so this should be good regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty bad oversight which might cause all sorts of issues, so we might want to pull it onto the 4.3 branch as well.
As fallout, we now hoist static locals inside unrollable loops in order to avoid duplicate declarations. Looking at this makes we wonder if we shouldn't always hoist local declarations in these cases to avoid declaring multiple variables unnecessarily.