Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move List to haxe.ds.List #6610

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Conversation

kevinresol
Copy link
Contributor

@back2dos
Copy link
Member

Seems to me that the question what to do with Lambda is quite strongly related ;)

@Simn
Copy link
Member

Simn commented Sep 25, 2017

Right, Lambda... How about this:

  1. Move current Lambda.hx to hx3compat
  2. Create std/haxe/Lambda.hx which only has the List-agnostic stuff, and maybe make it nicer in general (whatever I mean by that).

@Simn
Copy link
Member

Simn commented Sep 25, 2017

Also: I totally forgot about haxelib... oh man

@kevinresol
Copy link
Contributor Author

Added PR in haxelib

@Simn
Copy link
Member

Simn commented Sep 25, 2017

Nice, thanks!

... so how do we CI this properly? Or should I just merge both and hope for the best?

@kevinresol
Copy link
Contributor Author

Run on your machine? 😀

@back2dos
Copy link
Member

There's a bit of a problem in this case, which depends on the class name on quite a few platforms: https://github.com/HaxeFoundation/haxe/blob/development/std/haxe/Serializer.hx#L291

I guess matching against "haxe.ds.List" would work just fine.

@Simn Simn merged commit f0ef8c4 into HaxeFoundation:development Sep 25, 2017
@Simn
Copy link
Member

Simn commented Sep 25, 2017

Merged both PRs, let's see how it goes... and thanks!

@kevinresol
Copy link
Contributor Author

And you will have to update the haxelib ref

@Simn
Copy link
Member

Simn commented Sep 25, 2017

Right, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants