Remove old PHP target #6612
Merged
Remove old PHP target #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Should we take this opportunity to get rid of these --php-front etc. command line arguments? |
* [matcher] allow and encourage `case var <ident>` (see HaxeFoundation#6207) * [std] add `case var` everywhere * [matcher] give similarity warnings for plain idents * fix tests
|
Also we already have a conflict, sorry about that... |
We can remove
|
|
I think all of these should become But we can merge this first so it's out of the way. |
|
F |
|
|
back2dos
pushed a commit
to back2dos/haxe
that referenced
this pull request
Oct 5, 2021
* remove old PHP generator * remove failing test * remove more PHP code * renamed php7 stuff to php * some cleanup * cleanup * case var (HaxeFoundation#6608) * [matcher] allow and encourage `case var <ident>` (see HaxeFoundation#6207) * [std] add `case var` everywhere * [matcher] give similarity warnings for plain idents * fix tests * remove old PHP generator * remove failing test * remove more PHP code * renamed php7 stuff to php * some cleanup * cleanup * typo * resolve appveyor conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't push to @Simn's repo so i created a new PR instead of #6604