[js] move typed array classes from js.html to js.lib #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @Gama11! I'll apply this to the externs generator after this merges |
haxiomic
approved these changes
Feb 27, 2019
|
Nice! |
|
@nadako: If you approve this I'm fine with merging. |
|
Yeah I'm fine with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #7390 and #6586. I expect that this requires an update to the js.html externs generator. For now I've just done a find-and-replace.
This opens the possibility of forbidding access to the
js.htmlpackage when using hxnodejs, which should improve the code completion experience and performance.