Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] implement --wait-connect (see vshaxe/vshaxe#217) #8730

Merged
merged 3 commits into from
Sep 1, 2019

Conversation

nadako
Copy link
Member

@nadako nadako commented Aug 31, 2019

No description provided.

@nadako
Copy link
Member Author

nadako commented Aug 31, 2019

Not sure about the argument name, maybe it should be --connect-wait or something completely different?

@Simn
Copy link
Member

Simn commented Sep 1, 2019

How about:

  • --server-wait for --wait
  • --server-connect for --wait-connect
  • --client for --connect

Keeping --wait and --connect for compatibility of course.

@Simn
Copy link
Member

Simn commented Sep 1, 2019

Meh, --connect 6000 sounds better than --client 6000... never mind.

@RealyUniqueName
Copy link
Member

I think for tcp servers listen is kind of established term.

@Simn
Copy link
Member

Simn commented Sep 1, 2019

So --listen-wait and --listen-connect?

@Aurel300
Copy link
Member

Aurel300 commented Sep 1, 2019

--listen-connect sounds really strange. Just --listen?

@Simn
Copy link
Member

Simn commented Sep 1, 2019

But it connects.

@nadako
Copy link
Member Author

nadako commented Sep 1, 2019

--server-listen, --server-connect, --connect?

@Simn Simn marked this pull request as ready for review September 1, 2019 14:07
@Simn Simn mentioned this pull request Sep 1, 2019
@Simn Simn merged commit 196bdf7 into development Sep 1, 2019
@Simn Simn deleted the wait_connect branch September 1, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants