Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get compiler version for run scripts lazily #646

Merged

Conversation

tobil4sk
Copy link
Member

It only has to be checked when running interp scripts, so we can avoid checking it in other cases.

This can avoid running a haxe --version process in cases where that is problematic (such as when running a hxcpp build to build the haxelib binary: HaxeFoundation/haxe#11755).

It only has to be checked when running interp scripts, so we can avoid
checking it in other cases.
@Simn Simn merged commit 3a6aebf into HaxeFoundation:development Aug 30, 2024
2 checks passed
@tobil4sk tobil4sk deleted the fix/haxelib-run-compiler-check branch August 30, 2024 19:10
tobil4sk added a commit to tobil4sk/haxec that referenced this pull request Aug 30, 2024
We need HaxeFoundation/haxelib#646 because at
the time of running `$(HAXELIB_INTERP) run hxcpp ...`, no `haxe`
executable is available in PATH yet.
@skial skial mentioned this pull request Sep 4, 2024
1 task
tobil4sk added a commit to tobil4sk/haxec that referenced this pull request Sep 4, 2024
We need HaxeFoundation/haxelib#646 because at
the time of running `$(HAXELIB_INTERP) run hxcpp ...`, no `haxe`
executable is available in PATH yet.
ninjamuffin99 pushed a commit to FunkinCrew/haxelib that referenced this pull request Sep 18, 2024
It only has to be checked when running interp scripts, so we can avoid
checking it in other cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants