Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Host and Localhost tests #1115

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

Aidan63
Copy link
Contributor

@Aidan63 Aidan63 commented Jun 16, 2024

The Mac CI has been failing for quite some time now due to a host address resolution test which tries to resolve the localhost. Resolving localhost addresses on mac runners on github actions and azure pipelines has been broken for the last year or so.

actions/runner-images#8649

To work around this I've split up the tests. Using Host.localhost for testing if we can get the localhost address, and new Host("github.com") to test if we can resolve an address. Github should be a pretty safe url to test against.

With this hopefully the CI will be consistently green again!

@Simn Simn merged commit e1798e6 into HaxeFoundation:master Jun 16, 2024
6 checks passed
@Aidan63 Aidan63 deleted the ci-host-tests branch June 16, 2024 20:24
@skial skial mentioned this pull request Jun 25, 2024
1 task
@tobil4sk
Copy link
Member

@Aidan63 Note, testLocalHost() doesn't get run because it has to be called explicitly in the main() method in test/std/Test.hx. Was it omitted intentionally?

@Aidan63
Copy link
Contributor Author

Aidan63 commented Jun 25, 2024

Ah, no, that was an oversight on my part then. Must have assumed it was a utest project so any function starting with test would be auto ran. I'll get a fix for it this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants