Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to js.lib.* #123

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Update to js.lib.* #123

merged 1 commit into from
Apr 17, 2019

Conversation

RealyUniqueName
Copy link
Member

Closes #122

@RealyUniqueName RealyUniqueName requested a review from nadako April 17, 2019 08:10
@Gama11
Copy link
Member

Gama11 commented Apr 17, 2019

Hm, CI is still failing, even though I've just restarted the Haxe dev job. Looks like it's using a Haxe version from yesterday still:

$ echo $(haxe -version)
4.0.0-rc.2+2f98d03

@andyli I know you've tried something to help with that, any ideas?

@andyli
Copy link
Member

andyli commented Apr 17, 2019 •
edited
Loading

The DEPLOY_NIGHTLIES=1 job (the first one) of your commit failed: https://travis-ci.org/HaxeFoundation/haxe/builds/521135645

@Gama11
Copy link
Member

Gama11 commented Apr 17, 2019

Oh, that makes sense. So maybe it's working fine after all now. 👍

@Gama11
Copy link
Member

Gama11 commented Apr 17, 2019

Merging anyway, since locally it works fine with latest Haxe + these changes.

@Gama11 Gama11 merged commit aa87ee2 into HaxeFoundation:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadako nadako Awaiting requested review from nadako

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some js.* types moved to js.lib.*
3 participants
@RealyUniqueName @Gama11 @andyli