Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python wheels for the package and for the kernels #17

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

michaelfeil
Copy link

With this PR, you can click Release, and create a tag that starts of with wheels*, e.g. wheels-0.0.1. The wheel is created for each torch major and cuda version, I would recommend getting the right build from the right matrix.

Background: The CudaExtensions takes decent time in CI to build, I prefer to pin some version from the github release, over a clone + pip install -e .

Pipeline should be roughly reusable. I built it partially from scratch, partially from Autoawq. Its running under MIT Licence.

Cheers
Michael feil

@michaelfeil
Copy link
Author

This can be merged FYI

@DanFu09
Copy link
Contributor

DanFu09 commented Feb 26, 2024

Thanks so much for this PR, it looks really helpful.

Two requests:

  1. Do you know if there's a way to test the release build before merging?
  2. Can you please squash the commits into one?

@DanFu09 DanFu09 self-requested a review February 26, 2024 20:21
@michaelfeil
Copy link
Author

@DanFu09

  1. For squashing - could this be done in Github UI by you / merging?
  2. It could be possible to run the unit tests upon installation. Is this required?

@DanFu09
Copy link
Contributor

DanFu09 commented Mar 12, 2024

I don't think I can squash it, since it's a PR from your branch. I'm not an expert in github's online interfaces though :)

For the tests - I mean can we run the unit tests just once before merging them in to validate. (if you can run them and share a screenshot of the results that is good too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants