Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set longest_match_only to False by default for LambdaFunctionMatcher #165

Merged
merged 7 commits into from
Sep 27, 2018
Merged

Set longest_match_only to False by default for LambdaFunctionMatcher #165

merged 7 commits into from
Sep 27, 2018

Conversation

lukehsiao
Copy link
Contributor

Closes #161.

@lukehsiao lukehsiao added the bug Something isn't working label Sep 26, 2018
@lukehsiao lukehsiao added this to the v0.3.3 milestone Sep 26, 2018
@lukehsiao lukehsiao self-assigned this Sep 26, 2018
@lukehsiao lukehsiao requested review from j-rausch and senwu September 26, 2018 17:26
senwu
senwu approved these changes Sep 26, 2018
View reviewed changes
Copy link
Collaborator

@senwu senwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this?

@lukehsiao lukehsiao removed the request for review from j-rausch September 26, 2018 18:25
@lukehsiao
Copy link
Contributor Author

@j-rausch Can you help add a test case?

@lukehsiao lukehsiao removed their assignment Sep 26, 2018
@lukehsiao lukehsiao merged commit 7efe31b into master Sep 27, 2018
@lukehsiao lukehsiao deleted the patch-lambdamatcher branch September 27, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senwu senwu senwu approved these changes

Assignees

@j-rausch j-rausch

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lukehsiao @senwu @j-rausch