Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation key tables to support multiple relations #167

Merged
merged 16 commits into from
Oct 17, 2018

Conversation

lukehsiao
Copy link
Contributor

@lukehsiao lukehsiao commented Oct 11, 2018

Currently the Feature, Label, and Gold Label key matrices have a bug where updating/dropping keys a single relation can inadvertently corrupt the key table for other relations.

@lukehsiao lukehsiao added the bug Something isn't working label Oct 11, 2018
@lukehsiao lukehsiao self-assigned this Oct 11, 2018
@lukehsiao lukehsiao added this to the v0.3.4 milestone Oct 11, 2018
@senwu senwu self-requested a review October 12, 2018 09:00
Copy link
Collaborator

@senwu senwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/e2e/test_e2e.py Show resolved Hide resolved
CHANGELOG.rst Show resolved Hide resolved
@lukehsiao lukehsiao force-pushed the annotation_keys branch 2 times, most recently from 262c684 to dd8c537 Compare October 16, 2018 06:30
Copy link
Collaborator

@senwu senwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukehsiao lukehsiao changed the title [WIP] Fix annotation key tables to support multiple relations Fix annotation key tables to support multiple relations Oct 17, 2018
@lukehsiao lukehsiao merged commit a340084 into master Oct 17, 2018
@lukehsiao lukehsiao deleted the annotation_keys branch October 17, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants