Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mac parallel constrict in e2e test #176

Merged
merged 11 commits into from
Nov 5, 2018
Merged

remove mac parallel constrict in e2e test #176

merged 11 commits into from
Nov 5, 2018

Conversation

senwu
Copy link
Collaborator

@senwu senwu commented Nov 2, 2018

No description provided.

Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is fixed in spaCy, we should update all the tests to just use a single parallelism.

@senwu
Copy link
Collaborator Author

senwu commented Nov 2, 2018

Agree! It passed on my mac, I am testing it on Travis now. We should have single parallelism and multiple parallelisms in our tests to make sure both cases work.

Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants