Fix get_last_documents to return valid Document objects
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehsiao
changed the title
get_last_documents get_last_documents to return valid Document objects
…the db The previous implementation would track the last parsed documents using a set of Document objects returned by a Preprocesser. Thus, when a user called `get_last_documents`, they would get Documents, but not Documents which had any linkage to the underlying database, and thus could not view the document's ID, or relationships like Sentences. This commit is twofold. First, we move the `get_last_documents` call implementation to the Parser, rather than having it in the UDF. This just makes more organizational sense. Second, it queries the database for Documents by filtering on the names of the last documents, ensuring that the returned documents can be navigated by the user (e.g., to view the Sentences).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation would track the last parsed documents using
a set of Document objects returned by a Preprocesser. Thus, when a user
called
get_last_documents, they would get Documents, but not Documentswhich had any linkage to the underlying database, and thus could not
view the document's ID, or relationships like Sentences.
This commit is twofold. First, we move the
get_last_documentscallimplementation to the Parser, rather than having it in the UDF. This
just makes more organizational sense. Second, it queries the database
for Documents by filtering on the names of the last documents, ensuring
that the returned documents can be navigated by the user (e.g., to view
the Sentences).