fix: synchronize session on all deletes #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds session synchronization to all delete queries in fonduer. Note that this does have performance implications. Specifically: > The 'fetch' strategy results in an additional SELECT statement emitted > and will significantly reduce performance. from [1]. [1]: https://docs.sqlalchemy.org/en/latest/orm/query.html Closes #213.
lukehsiao
force-pushed
the
sync-session
branch
from
11697c5 to
a1d6d8f
Compare
senwu
approved these changes
Feb 7, 2019
|
Does this fix the #213 ? |
|
Yes, it does for me. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does have some performance implications [1]:
But some overhead in performance when running
clearandclear_all()seems worth it if it eliminates the sqlalchemy error.See #213.