Workaround no longer required as of spaCy v2.1.0 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current master branch requires spaCy v2.1.3 or later. Feel free to update this PR. |
The issue (explosion/spaCy#2901) has been resolved by explosion/spaCy#3065. Note that this workaround has never been required for Chinese.
HiromuHota
force-pushed
the
refactor/130
branch
from
2681e24 to
72cddff
Compare
|
This appears to pass our tests. Is this tested? If so, it would be nice to include in v0.6.1. |
|
I've tested it. It's ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue (explosion/spaCy#2901) has been resolved by explosion/spaCy#3065.
This PR is still WIP as I haven't tested it.