Use singleton-like Meta class to store global state #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot conditionally initialize the database tables in the context classes because snorkel_postgres is only initialized after the imports. Because we won't support sqlite (see #35), just initialize the context based on using postgres.
|
This release is NOT backwards compatable with v0.1.4. Specifically, in order os.environ['SNORKELDB'] = 'postgres://localhost:5432/' + DBNAME
from fonduer import SnorkelSession
session = SnorkelSession()which had the side-effects of manipulating your database tables on import (or creating a from fonduer import Meta
session = Meta.init("postgres://localhost:5432/" + DBNAME).SnorkelSession()No side-effects occur until |
lukehsiao
changed the title
senwu
reviewed
Mar 30, 2018
tests/e2e/test_e2e.py
Outdated
| def test_e2e(caplog): | ||
| """Run an end-to-end test on 20 documents of the hardware domain.""" | ||
| caplog.set_level(logging.INFO) | ||
| PARALLEL = 2 | ||
| max_docs = 12 | ||
|
|
||
| session = SnorkelSession() | ||
| session = Meta.init('postgres://localhost:5432/' + DB).SnorkelSession() |
There was a problem hiding this comment.
Can we update the name here (FonduerSession)?
tests/parser/test_parser.py
Outdated
| @@ -29,6 +25,7 @@ def test_parse_structure(caplog): | |||
| """ | |||
| caplog.set_level(logging.INFO) | |||
| logger = logging.getLogger(__name__) | |||
| session = Meta.init('postgres://localhost:5432/' + ATTRIBUTE).SnorkelSession() | |||
tests/parser/test_parser.py
Outdated
| @@ -77,7 +74,7 @@ def test_parse_document_md(caplog): | |||
| This tests both the structural and visual parse of the document. | |||
| """ | |||
| logger = logging.getLogger(__name__) | |||
| session = SnorkelSession() | |||
| session = Meta.init('postgres://localhost:5432/' + ATTRIBUTE).SnorkelSession() | |||
tests/parser/test_parser.py
Outdated
| @@ -126,7 +123,7 @@ def test_parse_document_diseases(caplog): | |||
| """ | |||
| caplog.set_level(logging.INFO) | |||
| logger = logging.getLogger(__name__) | |||
| session = SnorkelSession() | |||
| session = Meta.init('postgres://localhost:5432/' + ATTRIBUTE).SnorkelSession() | |||
senwu
reviewed
Mar 30, 2018
docs/index.rst
Outdated
| dev/tests | ||
| :maxdepth: 2 | ||
| :caption: Developer Documentation | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34.