Split sqlalchemy models into individual files #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both needed to be split at once in order to avoid a circular dependency.
senwu
reviewed
Jun 30, 2018
fonduer/parser/models/__init__.py
Outdated
| from fonduer.parser.models.context import Context, construct_stable_id, split_stable_id | ||
| from fonduer.parser.models.document import Document | ||
| from fonduer.parser.models.figure import Figure | ||
| from fonduer.parser.models.image import Image, TemporaryImage |
There was a problem hiding this comment.
This is for candidate generation?
fonduer/parser/models/__init__.py
Outdated
| from fonduer.parser.models.figure import Figure | ||
| from fonduer.parser.models.image import Image, TemporaryImage | ||
| from fonduer.parser.models.phrase import Phrase | ||
| from fonduer.parser.models.span import ( |
There was a problem hiding this comment.
This is for candidate generation?
|
Following up on our conversation, will move the classes that are specific to candidate generation, and not core to the data model, into the candidate generation phase (e.g., Image, ImplicitSpan, Span). |
stackoverflowed
pushed a commit
to stackoverflowed/multimodal
that referenced
this pull request
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57.