reorg_lf_helpers #81
Merged
reorg_lf_helpers #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehsiao
reviewed
Jul 21, 2018
fonduer/supervision/lf_helpers.py
Outdated
| from fonduer.supervision.utils.structural import * | ||
| from fonduer.supervision.utils.tabular import * | ||
| from fonduer.supervision.utils.textual import * | ||
| from fonduer.supervision.utils.visual import * |
There was a problem hiding this comment.
I think the correct way to organize this so that the imports to the user is the same is to make lf_helpers the directory with an init.py, and having the separate modaility helper files in that directory, rather than making a utils directory. If that sounds OK to you, I can take care of that update.
There was a problem hiding this comment.
That's sound right! Thanks!
lukehsiao
approved these changes
Jul 21, 2018
| ) | ||
|
|
||
|
|
||
| def is_superset(a, b): |
There was a problem hiding this comment.
This function and overlap() seemed too general to be in tabular.py, so I moved them here.
| return | ||
|
|
||
|
|
||
| def get_visual_header_ngrams(c, axis=None): |
There was a problem hiding this comment.
I don't expose these unimplemented helpers in the __init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.