Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen Keras' version restriction, which is now unnecessarily strict #68

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Loosen Keras' version restriction, which is now unnecessarily strict #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f095c9
Loosen Keras' version restriction, which is now unnecessarily strict
Oct 1, 2020
66d9288
Correctly use the vision-based model
Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed
- [@HiromuHota][HiromuHota]: Loosen Keras' version restriction, which is now unnecessarily strict.
([#68](https://github.com/HazyResearch/pdftotree/pull/68))

### Fixed
- [@HiromuHota][HiromuHota]: Fix a bug that an html file is not created at a given path.
([#64](https://github.com/HazyResearch/pdftotree/pull/64))
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
install_requires=[
"IPython",
"beautifulsoup4",
"keras==2.0.8",
"keras>=2.0.8,<2.4.0", # keras>=2.4.0 requires TensorFlow 2.2 or higher
"numpy",
"pandas",
"pdfminer.six>=20191020",
Expand Down
6 changes: 3 additions & 3 deletions tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ def test_ml_completion():
assert output is not None


def test_visual_completion():
"""Simply test that ML-based parse runs without errors."""
def test_vision_completion():
"""Simply test that vision-based parse runs without errors."""
output = pdftotree.parse(
"tests/input/paleo.pdf",
model_type="visual",
model_type="vision",
model_path="tests/input/paleo_visual_model.h5",
)
assert output is not None