Skip to content

Net standard support #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2017

Conversation

LeeCampbell
Copy link
Collaborator

Another (4th?) attempt to target #17.
Recreated from scratch with the new VS2017 (15.2) IDE and csproj file formats.
While this was painful to make the port, the build seems so much more simple now.
dotnet cli (+ MSBuild under the hood) can now version, compile, test and package. 🎉

Key changes in this PR

  • Finally made the jump to XUnit. In the end this only required minor changes. But the tooling is far better supported the nUnit and I just couldn't get nUnit to work as documented.
  • Multi-target .net45 and netstandard1.3
  • Version bump to 2.x.x
  • Unit test use a custom spin wait class. Was seeing unpredictable Thread Sleep duration. This was part a misunderstanding on my behalf (thread.sleep will sleep at least as long as specified), and XUnit multithreaded runner taking all the threads (assumption). As a hammer, I have made the tests single threaded.
  • Builds are now all using the dotnet cli. This means no powershell or fancy build scripts. See build.cmd to see how simple it is now.

Big thanks to @alhardy, @dtillman, @onovotny and ghuntley for their help (directly or indirectly) getting this PR ready.

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@LeeCampbell LeeCampbell force-pushed the NetStandardSupport branch from 1aefe1d to eb85319 Compare June 3, 2017 04:39
@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

This was referenced Jun 3, 2017
@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@LeeCampbell LeeCampbell merged commit 1d516f9 into HdrHistogram:master Jun 20, 2017
@LeeCampbell LeeCampbell deleted the NetStandardSupport branch June 20, 2017 02:06
@LeeCampbell LeeCampbell mentioned this pull request Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants