Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component: Confirmation Modal #1706

Closed
corykon opened this issue Nov 3, 2021 · 4 comments
Closed

New component: Confirmation Modal #1706

corykon opened this issue Nov 3, 2021 · 4 comments
Assignees

Comments

@corykon
Copy link
Collaborator

corykon commented Nov 3, 2021

Confirmation modals are super common in our apps. We already have generic modals, but we should set up a standard component specifically for this use case to make sure the confirmation experience is aligned.

Leading Wisely just made a nice confirmation modal component that we could port over:
image

image

image

image

@corykon
Copy link
Collaborator Author

corykon commented Nov 3, 2021

@andrew-frueh thoughts on the styles? Wondering if the spacing/sizing could be dialed in. Some cashmere and non-cashmere variations

image
image
image

On this one - don't like that the buttons are both blue, but love how minimalist it is. Rather than header and a message, sometimes just a one liner and the action buttons are enough.
image

@corykon corykon self-assigned this Nov 5, 2021
@corykon
Copy link
Collaborator Author

corykon commented Nov 12, 2021

Note:

  • Option to have no header
  • Double check styles work well for small screens

@corykon corykon added the v12 label Nov 12, 2021
@andrew-frueh
Copy link
Collaborator

@corykon - if you end up building this one, make sure to include the FocusTrap enhancements/options just added to modal in #1747

@corykon corykon removed the v12 label Dec 6, 2021
@corykon
Copy link
Collaborator Author

corykon commented Mar 23, 2023

Picking this up to work on now, for a CDP use case.

corykon added a commit to corykon/Fabric.Cashmere that referenced this issue Mar 27, 2023
provide a minimal code for experience common modal use cases

re HealthCatalyst#1706
@corykon corykon closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants