fix(input): mark as touched on blur #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force an input element to mark its ngControl as touched on blur closes HealthCatalyst#2116
corykon
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force an input element to mark its ngControl as touched on blur
@JDavidStevens @corykon - this was an interesting one because it happens in Chrome but not Firefox. The issue is that the
ngControlon our inputDirective isn't being marked astouchedon blur (or it's happening after the blur event). And with our validation step, it won't mark the control as invalid unless it's been touched. So what I've done here is force the control to be marked as touched on blur (which it should be doing anyway) before the validation gets called. With that change, the test you mentioned checks out.closes #2116