[prefab] Properly pre allocate children array

HeapsIO · Mar 27, 2024 · 5f3a57f · 5f3a57f
1 parent a4937f6
commit 5f3a57f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/hrt/prefab/Macros.hx b/hrt/prefab/Macros.hx
@@ -762,7 +762,12 @@ class Macros {
 							else
 							{
 								var _a : Array<Dynamic> = cast $e{source};
-								[for (_elem in _a) $e{hrt.prefab.Macros.deepCopyRec(params[0], macro @:pos(source.pos) _elem, targetType, null, custom, true)}];
+								var target = [];
+								target.resize(_a.length);
+								for (idx => _elem in _a) {
+									target[idx] = $e{hrt.prefab.Macros.deepCopyRec(params[0], macro @:pos(source.pos) _elem, targetType, null, custom, true)};
+								}
+								target;
 							}
 						};
 					case "String":

diff --git a/hrt/prefab/Prefab.hx b/hrt/prefab/Prefab.hx
@@ -199,8 +199,14 @@ class Prefab {
 
 		inst.copy(this);
 		if (withChildren) {
-			for (child in children) {
-				child.clone(inst, sh);
+			inst.children.resize(children.length);
+			for (idx => child in children) {
+				var cloneChild = child.clone(null, sh);
+
+				// "parent" setter pushes into children, but we don't want that
+				// as we have prealocated the array children
+				@:bypassAccessor cloneChild.parent = inst;
+				inst.children[idx] = cloneChild;
 			}
 		}