Improve python and boost package finding in CMake. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of custom commands, find_package( python …) is used and provide variables for include directories and site packages. In the same time recent versions of Boost (~>1.70) don't provide "python" module but "python27", "python35" etc… modules. Python version is used to retrieve name of boost python module. User can still control python version with advanced option "PYTHON_VERSION"
neomilium
requested changes
Sep 26, 2020
| OUTPUT_VARIABLE Python_Includes | ||
| ) | ||
| message(STATUS "Python include dir:" ${Python_Includes}) | ||
| set(PYTHON_VERSION 3.6) |
There was a problem hiding this comment.
This can not be hardcoded... Python version must be detected as it depends on the target system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of custom commands, find_package( python …) is used and
provide variables for include directories and site packages.
In the same time recent versions of Boost (~>1.70) don't provide
"python" module but "python27", "python35" etc… modules.
Python version is used to retrieve name of boost python module.
User can still control python version with advanced option
"PYTHON_VERSION"