WEG-11 TrainerTab Pagination #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TehAwol
commented
Jun 9, 2024
TehAwol
commented
- Add Pagination query for Game
- Simplify TrainerTab filters
| public Page<Game> paginatedGames(@PathParam("status") final Game.Status status, | ||
| @QueryParam("page") int page, | ||
| @QueryParam("size") int size, | ||
| @QueryParam("query") String query) { |
There was a problem hiding this comment.
Allowed chars should be restricted, like:
Suggested change
| @QueryParam("query") String query) { | |
| @QueryParam("query")@Pattern(regexp = "^[\\p{L} .'-[0-9]]*$") String query) { |
Could you please add this to Usercontroller.paginatedUsers as well?
(regex to be tested)
There was a problem hiding this comment.
Added issue in Jira as we need to check against GameModels and Games name regex
xgo-work
reviewed
Jun 19, 2024
| @@ -303,7 +300,7 @@ public void remove(final Game entity) { | |||
|
|
|||
| // This is for retrocompatibility w/ game models that do not habe DebugGame | |||
| if (entity.getGameModel().getGames().size() <= 1 | |||
| && !(entity.getGameModel().getGames().get(0) instanceof DebugGame)) {// This is for retrocompatibility w/ game models that do not habe DebugGame | |||
| && !(entity.getGameModel().getGames().get(0) instanceof DebugGame)) {// This is for retrocompatibility w/ game models that do not habe DebugGame | |||
There was a problem hiding this comment.
Might throw out of bounds exception, do we care ?
| * Get all games with given status paginated | ||
| * | ||
| */ | ||
| @GET |
There was a problem hiding this comment.
Best would be to use a POST
| List<Game.Status> gStatuses = new ArrayList<>(); | ||
| gStatuses.add(status); | ||
|
|
||
| Map<Long, List<String>> gMatrix = this.getPermissionMatrix(gStatuses); |
There was a problem hiding this comment.
Should paginate this as well to be future proof, if no time then create a story for improvement (3500 games in db), but make sur it will work for a while with prod db
xgo-work
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.