Pagination #1967
Merged
Pagination #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SandraMonnier
commented
Jul 17, 2024
SandraMonnier
commented
- addition of pagination on scenarist tab
- review of some trainer pagination
- refactor useEffects - do not use GameState.status. They cannot be used with filtered results received from the back-end - totalResults is kept in the page. No use or need to put it in the store
- we keep the games in store when fetched - on trainerTab, we fetch only the games matching the games' id received from the server-side
- refactor useEffects - do not use GameModelState.status. They cannot be used with filtered results received from the back-end - totalResults is kept in the page. No use or need to put it in the store
- we fetch from the server only the game models matching the requested permissions - we keep the game models in store when fetched - on scenaristTab, we fetch only the game models matching the game models' id received from the server-side
xgo-work
reviewed
Jul 17, 2024
wegas-app/src/main/node/wegas-lobby/src/components/scenarist/ScenaristTab.tsx
Show resolved
Hide resolved
xgo-work
reviewed
Jul 17, 2024
wegas-app/src/main/node/wegas-lobby/src/components/scenarist/ScenaristTab.tsx
Outdated
Show resolved
Hide resolved
xgo-work
reviewed
Jul 17, 2024
wegas-core/src/main/java/com/wegas/core/ejb/GameModelFacade.java
Outdated
Show resolved
Hide resolved
aka creation, status change, deletion NB : reload does not work with permission change
xgo-work
reviewed
Jul 18, 2024
xgo-work
reviewed
Jul 18, 2024
xgo-work
reviewed
Jul 18, 2024
wegas-app/src/main/node/wegas-lobby/src/components/trainer/TrainerTab.tsx
Show resolved
Hide resolved
xgo-work
reviewed
Jul 18, 2024
wegas-app/src/main/node/wegas-lobby/src/selectors/wegasSelector.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: xgo-work <71324808+xgo-work@users.noreply.github.com>
Co-authored-by: xgo-work <71324808+xgo-work@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.