Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pmg 10 #2006

Merged
merged 12 commits into from
Jan 10, 2025
Merged

Pmg 10 #2006

merged 12 commits into from
Jan 10, 2025

Conversation

xgo-work
Copy link
Contributor

@xgo-work xgo-work commented Jan 7, 2025

Improved the questions display component

  • results are displayed directly under the chosen answer
  • counters for answers that can be answered multiple times
  • counters in question list
  • css selectors added

@@ -76,21 +76,24 @@ export const choiceLabelStyle = css({
color: themeVar.colors.LightTextColor,
backgroundColor: themeVar.colors.PrimaryColor,
},
});
export const choiceDescriptionStyle = css({
}), 'wegas-question__choice-label');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have have them inline or in styles ? Open question

width: '100%',
padding: '10px 15px 10px 15px',
});
export const choiceButtonStyle = css({
}), 'wegas-question__choice-description');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline

flexDirection: 'row',
display: 'flex',
justifyContent: 'end'
}), 'wegas-question__choice-button');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline

display: 'flex',
flexDirection: 'column',
justifyContent: 'center',
padding: '5px',
});
}), 'wegas-question__choice-input');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline

Copy link
Member

@SandraMonnier SandraMonnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the code quickly. Everything is fine for me. I trust you completely

@SandraMonnier SandraMonnier merged commit 024999f into dev Jan 10, 2025
1 check passed
@SandraMonnier SandraMonnier deleted the PMG-10 branch January 10, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants