Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: funnel options section shouldn't be embedded in potions group #4428

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

johnnylam88
Copy link
Contributor

Move the funnel options group out of the potions options group. It looks like an obvious error that slipped through.

Move the `funnel` options group out of the `potions` options group. It
looks like an obvious error that slipped through.
@johnnylam88
Copy link
Contributor Author

I'm actually not sure from reading the code whether the Funnel toggle was working or not. I'm also unsure if this needs some sort of one-time fix to SavedVariables depending on what's written in the profile to disk.

@syrifgit
Copy link
Collaborator

syrifgit commented Feb 28, 2025

I'm actually not sure from reading the code whether the Funnel toggle was working or not. I'm also unsure if this needs some sort of one-time fix to SavedVariables depending on what's written in the profile to disk.

It definitely does work. Does the UI still look the same by moving it?

It does, all good.

@johnnylam88
Copy link
Contributor Author

I took a look at my SavedVariables file for Hekili to see if there was any funnel toggle that was saved, but it looks like there wasn't. I think we can avoid needing any additions to the oneTimeFixes table. This should be ready to merge.

@Hekili Hekili merged commit 6c05fd0 into Hekili:thewarwithin Mar 1, 2025
@johnnylam88 johnnylam88 deleted the fix/options-funnel-potions branch March 1, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants