Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present changes are meant to correct the meshing along lines, and prevent overrefinement, giving users more control on the mesh sizes.
The addition of the
Allows us to see a significant change on the mesh due to changes in the resolution definitions of LineStrings, and the second part follows from the gmsh manual, in chapter 1:
This will allow us to go from this kind of meshing when
distance=0
:To this:
Which can be desirable.
Disclaimer: I'm not sure how much of a mess the commit history of my fork is. If it's too much trouble I'd be happy to close this PR and you guys can just make the necessary changes, if you see this would benefit the package as a whole.