[FIX][product_variant_default_code] check code of active value_ids

HeliconiaIO · Apr 25, 2023 · 20320aa · 20320aa
1 parent 5fa4d31
commit 20320aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/product_variant_default_code/__manifest__.py b/product_variant_default_code/__manifest__.py
@@ -15,7 +15,7 @@
     "license": "AGPL-3",
     "category": "Product",
     "maintainers": ["Kev-Roche"],
-    "depends": ["product"],
+    "depends": ["product", "product_attribute_archive"],
     "data": [
         "security/product_security.xml",
         "data/ir_config_parameter.xml",

diff --git a/product_variant_default_code/models/product.py b/product_variant_default_code/models/product.py
@@ -215,7 +215,11 @@ def _inverse_default_code(self):
             rec.manual_code = bool(rec.default_code)
 
     def _generate_default_code(self):
-        value_codes = self.product_tmpl_id.attribute_line_ids.value_ids.mapped("code")
+        value_codes = [
+            rec.code
+            for rec in self.product_tmpl_id.attribute_line_ids.value_ids
+            if rec.active
+        ]
         if (not self.code_prefix and self.product_tmpl_id.is_automask()) or not all(
             value_codes
         ):